Skip to content

MSC3288: Add room type to /_matrix/identity/v2/store-invite API #3288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2021
Merged

MSC3288: Add room type to /_matrix/identity/v2/store-invite API #3288

merged 10 commits into from
Oct 23, 2021

Conversation

@BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 20, 2021 •
edited by turt2live
Loading

@BillCarsonFr BillCarsonFr force-pushed the bca/make_email_invite_space_aware branch from 872c06f to 7f8f9e1 Compare July 20, 2021 16:20
@turt2live turt2live changed the title add room type in store invite MSC3288: Add room type in store invite Jul 20, 2021
@turt2live turt2live added identity service kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Jul 20, 2021
t3chguy
t3chguy reviewed Jul 20, 2021
View reviewed changes
deepbluev7
deepbluev7 reviewed Jul 20, 2021
View reviewed changes
This was referenced Jul 20, 2021
Merged
Merged
clokep
clokep reviewed Jul 21, 2021
View reviewed changes
Sorunome
Sorunome reviewed Jul 24, 2021
View reviewed changes
@BillCarsonFr BillCarsonFr mentioned this pull request Jul 27, 2021
Merged
turt2live
turt2live approved these changes Aug 25, 2021
View reviewed changes
@turt2live
Copy link
Member

This seems pretty straightforward

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Aug 25, 2021 •
edited
Loading

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • Unresolved suggestions

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Aug 25, 2021
@richvdh richvdh changed the title MSC3288: Add room type in store invite MSC3288: Add room type to /store-invite API Aug 31, 2021
@richvdh richvdh changed the title MSC3288: Add room type to /store-invite API MSC3288: Add room type to /_matrix/identity/v2/store-invite API Aug 31, 2021
richvdh
richvdh reviewed Aug 31, 2021
View reviewed changes
@turt2live
Copy link
Member

@mscbot concern Unresolved suggestions

@turt2live turt2live merged commit ee39dbb into matrix-org:old_master Oct 23, 2021
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Oct 23, 2021
This was referenced Oct 26, 2021
Merged
Merged
@turt2live turt2live self-assigned this Dec 30, 2021
@turt2live turt2live mentioned this pull request Dec 31, 2021
Merged
@turt2live
Copy link
Member

Spec PR: #3610

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Dec 31, 2021
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 17, 2022
@zecakeh zecakeh mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clokep clokep clokep left review comments

@anoadragon453 anoadragon453 anoadragon453 left review comments

@richvdh richvdh richvdh left review comments

@t3chguy t3chguy t3chguy left review comments

@turt2live turt2live turt2live approved these changes

+2 more reviewers

@Sorunome Sorunome Sorunome left review comments

@deepbluev7 deepbluev7 deepbluev7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

identity service kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

Spec Core Team Workflow
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@BillCarsonFr @turt2live @mscbot @richvdh @clokep @anoadragon453 @t3chguy @Sorunome @deepbluev7